exclude jan extension web from desktop build #6419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmauur
approved these changes
Sep 11, 2025
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 758b988 in 1 minute and 31 seconds. Click for details.
- Reviewed
19lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/vite.config.ts:34
- Draft comment:
Add inline comment to explain why '@jan/extensions-web' is excluded in optimizeDeps. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a build configuration change that excludes a specific package from optimization. While documentation can be helpful, the suggestion is asking for explanation rather than pointing out a clear issue. The comment is more of a "nice to have" than identifying a problem that needs fixing. Per the rules, we should not make purely informative comments or ask for explanations. Perhaps understanding why this package is excluded is important for maintainability and could prevent future issues if someone removes this configuration without knowing its purpose. While documentation can be valuable, our rules explicitly state not to make purely informative comments or ask for explanations. The code change itself is clear and functional without the suggested comment. Delete this comment as it only requests additional documentation without identifying any actual code issues that need fixing.
2. web-app/vite.config.ts:38
- Draft comment:
Include a brief comment on why '@jan/extensions-web' is marked external in rollupOptions. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to provide additional information about a specific configuration in the code. It is not a direct code suggestion or a request for a test, and it doesn't point out a potential issue or improvement. It seems to be asking for clarification, which violates the rule against asking the PR author to explain or confirm their intention.
Workflow ID: wflow_SrF0BkrILxVq4eFR
You can customize 
qnixsynapse
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fixes Issues
Self Checklist
Important
Exclude
@jan/extensions-webfrom desktop build invite.config.ts.@jan/extensions-webfrom dependency optimization invite.config.ts.@jan/extensions-webas external in the Rollup options invite.config.ts.This description was created by
for 758b988. You can customize this summary. It will automatically update as commits are pushed.